MEN-9322 + partial MEN-9001 - deployment creation things - #2144
Open
mzedel wants to merge 20 commits into
Open
Conversation
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
… utils Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
…d design Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
…se definitions - also mode conversion + basic phase management actions Ticket: MEN-9001 Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Ticket: MEN-9001 Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
…ions Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
…ions Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
- extracted phase payload assembly to reduce cognitive complexity Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
…lying component - also added type infos Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- also adjusted docs links appearance & targets - let date time picker rely on the commonly used format to increase alignment Ticket: MEN-9322 Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
- this handles rollout pattern, pause settings & device limit expansion explicitly Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
…rrors Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Ticket: MEN-9322 Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
…ng & design Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>
mineralsfree
left a comment
mineralsfree
left a comment
Contributor
There was a problem hiding this comment.
a few things I noticed, some of them worth fixing before merging IMO
Comment on lines
+306
to
+309
| const { hasError, hasWarning } = messages.reduce( | ||
| (accu, { severity }) => ({ hasError: accu.hasError || severity === 'error', hasWarning: accu.hasWarning || severity === 'warning' }), | ||
| { hasError: false, hasWarning: false } | ||
| ); |
Contributor
There was a problem hiding this comment.
Maybe
const hasError = messages.some(({ severity }) => severity === 'error');
const hasWarning = messages.some(({ severity }) => severity === 'warning');
Comment on lines
+33
to
+37
| const percentage = phases.reduce((accu, phase, index, source) => { | ||
| if (index === source.length - 1) { | ||
| return accu; | ||
| } | ||
| return phase.batch_size ? accu - phase.batch_size : accu; |
Contributor
There was a problem hiding this comment.
consider
phases.slice(0, -1).reduce((accu, { batch_size_devices = 0 }) => accu + batch_size_devices, 100);
| return `${toFixedWithoutRounding(number)}K`; | ||
| } | ||
| return count.toLocaleString(); | ||
| }; |
Contributor
There was a problem hiding this comment.
Maybe we could use something like
const deviceCountFormatter = new Intl.NumberFormat('en-US', { notation: 'compact', roundingMode: 'trunc' });
export const formatDeviceCount = (count: number): string => (Number.isFinite(count) && count >= 0 ? deviceCountFormatter.format(count) : '0');
instead?
| <TableCell> | ||
| {!isLast && phases.length > 1 ? ( | ||
| <div className="flexbox"> | ||
| <IconButton onClick={() => repeatPhase(index)} title="Repeat phase"> |
Contributor
There was a problem hiding this comment.
Maybe disable/remove when phase > 50%? Replacing all consequent phases might be not what user expects
| it('prefers the smallest whole-number unit', () => { | ||
| expect(parseInterval('86400s')).toEqual({ delay: 1, delayUnit: delayUnits.days }); | ||
| expect(parseInterval('7200s')).toEqual({ delay: 2, delayUnit: delayUnits.hours }); | ||
| expect(parseInterval('5400s')).toEqual({ delay: 30, delayUnit: delayUnits.minutes }); |
Contributor
There was a problem hiding this comment.
5400s is more than 30 minutes. 😄 parseInterval has incorrect implementation
| isPercentageMode={isPercentageMode} | ||
| hasError={hasError} | ||
| max={max} | ||
| disabled={isLast && deviceCount >= 1} |
Contributor
There was a problem hiding this comment.
I think we should not allow editing the last phase even if deviceCount == 0
| const phaseObject = { | ||
| 'Phase start time': <Time value={startTime} />, | ||
| 'Batch size': `${batchSize}%${deviceCountText}` | ||
| 'Batch size': isPercentageMode ? `${batchSize}%${deviceCountText}` : batchSize |
Contributor
There was a problem hiding this comment.
maybe : ${batchSize} ${pluralize('device', deviceCount)}
| const prefix = 'Uniform: '; | ||
| let phasesDescription = ''; | ||
| if (isPercentageMode) { | ||
| phasesDescription = `${batch_size}% per phase, ${delay}${delayUnit || delayDefaults.delayUnit} intervals`; |
Contributor
There was a problem hiding this comment.
${delay} ${delayUnit || delayDefaults.delayUnit}
maybe add space
| <ErrorOutlineIcon fontSize="small" style={{ marginRight: 4, top: 4, color: 'rgb(171, 16, 0)' }} /> | ||
| <InfoText> | ||
| <FormHelperText className="flexbox align-items-center"> | ||
| <ErrorOutlineIcon className=" margin-right-x-small" fontSize="small" color="error" /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <ErrorOutlineIcon className=" margin-right-x-small" fontSize="small" color="error" /> | |
| <ErrorOutlineIcon className="margin-right-x-small" fontSize="small" color="error" /> |
| return accu; | ||
| } | ||
| return phase.batch_size ? accu - phase.batch_size : accu; | ||
| }, 100); |
Contributor
There was a problem hiding this comment.
maybe phaseLimits.fullBatchPercentage instead of 100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.